Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: got rid of redundant isExpected in the Exception class #2328

Merged
merged 2 commits into from
Jul 3, 2024
Merged

refactor: got rid of redundant isExpected in the Exception class #2328

merged 2 commits into from
Jul 3, 2024

Conversation

amychisholm03
Copy link
Contributor

@amychisholm03 amychisholm03 commented Jul 3, 2024 •
edited
Loading

  • Got rid of the isExpected function in the Exception class to avoid duplication with the isExpected function in the error helper.

@amychisholm03 amychisholm03 self-assigned this Jul 3, 2024
@amychisholm03 amychisholm03 linked an issue Jul 3, 2024 that may be closed by this pull request
refactor: reduce duplication in the error helper #2322
Closed
jsumners-nr
jsumners-nr approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@jsumners-nr jsumners-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@amychisholm03 amychisholm03 merged commit 38f9825 into newrelic:main Jul 3, 2024
35 checks passed
@github-actions github-actions bot mentioned this pull request Jul 10, 2024
Merged
@amychisholm03 amychisholm03 deleted the error-helper branch July 12, 2024 18:26
@k2xl k2xl mentioned this pull request Aug 2, 2024
Closed
@ZinxValkyria ZinxValkyria mentioned this pull request Aug 3, 2024
Open
This was referenced Aug 13, 2024
Closed
Closed
@coderisnot coderisnot mentioned this pull request Aug 17, 2024
Open
@Abhi9705 Abhi9705 mentioned this pull request Aug 21, 2024
Open
@PoojaPanchal12 PoojaPanchal12 mentioned this pull request Aug 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsumners-nr jsumners-nr jsumners-nr approved these changes

Assignees

@amychisholm03 amychisholm03

Labels
None yet
Projects
Node.js Engineering Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor: reduce duplication in the error helper
2 participants
@amychisholm03 @jsumners-nr