fix: Add id to images inside author and topic articles queries #1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colincclark
reviewed
Nov 13, 2018
| title: `Some title ${imageIndex}`, | ||
| id: `e98c2${imageIndex | ||
| .toString() | ||
| .padStart(2)}c-cb16-11e7-b529-95e3fc05f40f`, |
There was a problem hiding this comment.
this feels a bit weird
There was a problem hiding this comment.
Saw this in other providers. I agree it's a bit weird but at least it ensures a certain level of uniqueness
| crop(ratio: $imageRatio) { | ||
| url | ||
| } | ||
| id |
There was a problem hiding this comment.
Its type is "uuid" but in apollo it's called "id" by default
colincclark
approved these changes
Nov 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apollo normalised cache has an issue which fails the network request if an object has an id in one query and doesn't have it in another. Added id to all image objects inside topic and author articles
Here is the error we are receiving at the moment:
Here is the related github issue for more details: apollographql/apollo-client#2510