Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve styles in OAuth and Magic Links sections #11942

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

halvaradop
Copy link
Contributor

☕️ Reasoning

This pull request improves the styles for the OAuth and Magic Links sections in the documentation by:

  • Centering elements in the Magic Links section to enhance layout consistency.
  • Fixing a rendering issue in the OAuth section on mobile devices caused by misaligned styles.

Screenshots

image

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

📌 Resources

Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 7:46pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Oct 1, 2024 7:46pm

Copy link

vercel bot commented Oct 1, 2024

@halvaradop is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @halvaradop! Greatly appreciated as always! 💚

I think the Magic Links section is due a search bar, similar to the OAuth providers, if you would like to work on it 👍

@balazsorban44 balazsorban44 merged commit e2f3d51 into nextauthjs:main Oct 1, 2024
11 of 13 checks passed
@halvaradop
Copy link
Contributor Author

halvaradop commented Oct 2, 2024

yes, with pleasure 🤠

However, I think it is better to enhance the existing OAuth code for similar implementations and then adjust the code for Magic links and future sections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants