feat: add slugify to select tab framework #11951
Open
+37
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
@halvaradop is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * @returns - A string parsed from the URL | ||
| */ | ||
| const parseParams = (url: string): string => { | ||
| let parsedUrl = url.toLowerCase().replaceAll(/[^a-zA-z]+/g, "-") |
Check warning
Code scanning / CodeQL
Overly permissive regular expression range Medium documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
This pull request adds slugification for framework tabs, allowing the currently selected framework's name to appear in the URL. The framework is determined based on the button container, as there is no direct access to the selected button. Additionally, the
Tabscomponent fromnextra/componentsautomatically updates the selected framework inlocalStorageunder theauthjs.codeTab.frameworkkey, using the index from the items prop.🧢 Checklist
🎫 Affected issues
📌 Resources