-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sveltekit): Refresh session cookie expiry & introduce auth
method
#9694
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
auth
method
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@sveltejs/kit@1.0.0-next.589 |
Co-authored-by: Balázs Orbán <info@balazsorban.com> Co-authored-by: Nico Domino <yo@ndo.dev>
Co-authored-by: Balázs Orbán <info@balazsorban.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
EDIT: Ah didn't see Balazs' comments until after reload
@ThangHuuVu I just tried this new The initial cookie set by the Do you have any idea why only the refreshed JWT cookie set by the new |
@kinglouie hi, if you see an issue, feel free to open an issue with a minimal reprodutible code and I will have a look 🙌 |
@@ -51,7 +51,7 @@ | |||
}, | |||
"peerDependencies": { | |||
"@sveltejs/kit": "^1.0.0 || ^2.0.0", | |||
"svelte": "^3.54.0 || ^4.0.0" || "^5" | |||
"svelte": "^3.54.0 || ^4.0.0 || ^5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently trying out the new Svelte 5 alongside with @auth/sveltekit.
I am currently using "svelte": "^5.0.0-next.69" but it's complaining about peerDependency still.
npm ERR! Could not resolve dependency:
npm ERR! peer svelte@"^3.54.0 || ^4.0.0 || ^5" from @auth/sveltekit@0.13.0
^5.0.0-next.69 should be working if ^5 is specfied right?
Closes #9497
getSession
toauth
to matchnext-auth
return valuebasePath
for SvelteKit - See feat: addbasePath
option #9686Fixes: #8034