Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable1] fix(REUSELicensesPlugin): Emit files in generateBundle hook to have real filenames #284

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Aug 7, 2024

Backport of PR #283

… real filenames

Otherwise the files contain the hash placeholder, as the hash is only generated just before `generateBundle`.
And Rollup does not replace the hash for other files, so we would end up with files like `foo-!{0001}.js.license`.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@backportbot backportbot bot requested review from ShGKme and susnux August 7, 2024 10:53
@backportbot backportbot bot added bug Something isn't working 3. to review Ready to review labels Aug 7, 2024
@susnux susnux merged commit b48c7a7 into stable1 Aug 7, 2024
11 checks passed
@susnux susnux deleted the backport/283/stable1 branch August 7, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Ready to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants