fix(NcAppNavigationItem): align utils with actions and other components #6054
Conversation
Signed-off-by: Grigory Vodyanov <scratchx@gmx.com>
GVodyanov
added
3. to review
GVodyanov
requested review from
ChristophWurst,
susnux,
GretaD and
marcoambrosini
| @@ -170,7 +170,7 @@ | |||
| /* counter */ | |||
| .app-navigation-entry__counter-wrapper { | |||
| // Add slightly more space to the right of the counter | |||
There was a problem hiding this comment.
this will change the counter space, did you test it with the counter? if it looks off?
There was a problem hiding this comment.
2 and 4 have a counter, 3 has actions
There was a problem hiding this comment.
I would argue it looks better now though
There was a problem hiding this comment.
If they are moved more to the right, the actions become misaligned with NcAppNavigationCaption, so unless you have any better ideas @susnux I would keep it the way it is currently
There was a problem hiding this comment.
That was no critic, just wanted to add screenshots for Gretas comment, I am fine with any of that :)
ShGKme
changed the title
|
Don't forget to add |
|
/backport to next |
☑️ Resolves
🖼️ Screenshots