2way sync: Better view handling

[tobiasKaminsky]

• empty state

• Tests written, or not not needed

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	60	62
Errors	3	3

SpotBugs

Category	Base	New
Bad practice	63	63
Correctness	64	64
Dodgy code	300	300
Experimental	1	1
Internationalization	7	7
Multithreaded correctness	6	6
Performance	53	53
Security	18	18
Total	512	512

Lint increased!

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13494.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[alperozturk96]

No need null check, you can use this. supportActionBar?.setDisplayHomeAsUpEnabled(true)

[alperozturk96]

You can omit the binding prefix for emptyList.
Instead of apply, use run when there’s no need to return a modified instance at the end of the block. Use apply only when assigning to a variable.

binding.list.run {
            setEmptyView(binding.emptyList.emptyListView)

            binding.emptyList.run {
                emptyListViewHeadline.run {
                    visibility = View.VISIBLE
                    setText(R.string.internal_two_way_sync_list_empty_headline)
                }
                emptyListViewText.run {
                    visibility = View.VISIBLE
                    setText(R.string.internal_two_way_sync_text)
                }
                emptyListIcon.run {
                    visibility = View.VISIBLE
                    setImageDrawable(
                        viewThemeUtils.platform.tintDrawable(
                            context,
                            R.drawable.ic_sync,
                            ColorRole.PRIMARY
                        )
                    )
                }
            }

            adapter = InternalTwoWaySyncAdapter(fileDataStorageManager, user.get(), context).apply {
                notifyDataSetChanged()
            }
            layoutManager = LinearLayoutManager(context)
        }

Alternatively you can omit second binding as well.

binding.run {
            list.run {
                setEmptyView(binding.emptyList.emptyListView)

                emptyList.run {
                    emptyListViewHeadline.run {
                        visibility = View.VISIBLE
                        setText(R.string.internal_two_way_sync_list_empty_headline)
                    }
                    emptyListViewText.run {
                        visibility = View.VISIBLE
                        setText(R.string.internal_two_way_sync_text)
                    }
                    emptyListIcon.run {
                        visibility = View.VISIBLE
                        setImageDrawable(
                            viewThemeUtils.platform.tintDrawable(
                                context,
                                R.drawable.ic_sync,
                                ColorRole.PRIMARY
                            )
                        )
                    }
                }

                adapter = InternalTwoWaySyncAdapter(fileDataStorageManager, user.get(), context).apply {
                    notifyDataSetChanged()
                }
                layoutManager = LinearLayoutManager(context)
            }
        }

[alperozturk96]

Add @SuppressLint("NotifyDataSetChanged") since code updates InternalTwoWaySyncAdapter items in onCreate