New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

secrets appear on errors in logfile #261

Merged

bigcat88 merged 1 commit into main from fix-secrets-leaks-in-logs

Apr 2, 2024

Member

bigcat88 commented Apr 2, 2024 •

edited

Loading

With PHP>=8.2 they will appear like this:

/var/www/html/apps-extra/app_api/lib/Service/AppAPIService.php
line 89
OCA\AppAPI\Service\AppAPIService->requestToExAppInternal(
  [
    "OCA\\AppAPI\\Db\\ExApp",
    3
  ],
  "POST",
  "http://host.docker.internal:9031/video_to_gif",
  [
    "SensitiveParameterValue"
  ]
)

Also adjustments in the Nextcloud Server required, to hide headers in IClient calls, we cannot do it from AppAPI side.


          fixed: secrets appear on errors in logfile

bb516c9

Signed-off-by: Alexander Piskun <bigcat88@icloud.com>

bigcat88 merged commit 1917ca8 into main

28 checks passed

bigcat88 deleted the fix-secrets-leaks-in-logs branch

April 2, 2024 13:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet