Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After upgrading 28.0.1 ftp module missing #2152

Closed
aol-nnov opened this issue Jan 27, 2024 · 12 comments
Closed

After upgrading 28.0.1 ftp module missing #2152

aol-nnov opened this issue Jan 27, 2024 · 12 comments

Comments

@aol-nnov
Copy link

aol-nnov commented Jan 27, 2024

After upgrading to 28.0.1, files app stopped showing user files.

It took me a while to discover the error message:

"File":"/var/www/html/apps/files_external/lib/Lib/Storage/FtpConnection.php","Line":37,"message":"Call to undefined function OCA\\Files_External\\Lib\\Storage\\ftp_connect()","exception":{},"CustomMessage":"Call to undefined function OCA\\Files_External\\Lib\\Storage\\ftp_connect()"}}

External storage support is a core app, shipped with nextcloud itself and we were using it to add external ftp server to the nextcloud instance. Out of blue everything stopped after upgrade. Thanks god, it's Sunday.

Interim solution is:

docker-php-ext-install ftp
docker-php-ext-enable ftp
apache2ctl restart

But its effect will be lost upon container restart.

Please re-add php ftp support into the nextcloud image.

P.S.: I'm using nextcloud:latest for quite a long period of time (i.e. for years ) and external ftp was working like a charm all the time

@aol-nnov

This comment has been minimized.

@J0WI
Copy link
Contributor

J0WI commented Jan 27, 2024

Duplicate of docker-library/php#1488

@J0WI J0WI marked this as a duplicate of docker-library/php#1488 Jan 27, 2024
@aol-nnov
Copy link
Author

aol-nnov commented Jan 27, 2024

@J0WI , they're not planning to bring it back by default. So, to my understanding, it is not a duplicate - now it's an issue of the nextcloud image.

@UserX404
Copy link

UserX404 commented Feb 2, 2024

thx @aol-nnov for bringing this ticket up. I also lost all my external shares.

@jansppenrade2
Copy link

This issue persists also in Nextcloud version 28.0.2.

@joshtrichards
Copy link
Member

So it seems we have two choices per upstream:

  • live without it (which would be a regression) but maybe document it with an example Dockerfile for local customization
  • add it to our base builds ourselves (example) since we can no longer inherit it from upstream

@itsthejb
Copy link

itsthejb commented Feb 12, 2024

Hi everyone,

Experienced this one also. On my side, not that inconvenient to just manually install it using the suggested solution. However, even with this it's still failing:

Screenshot 2024-02-12 at 17 21 42

The config of the mount points in settings are all green ticked as they were before and I couldn't find any error details. Has anyone found a solution for that?

Thanks!

@TE7
Copy link

TE7 commented Feb 12, 2024

Suggested solution works for me.

@J0WI
Copy link
Contributor

J0WI commented Feb 20, 2024

SFTP does still work. Do you have a special requirement that depends on plain FTP?

@aol-nnov
Copy link
Author

I do not need encryption on my isolated network, but I need to transfer high volumes of data, thus plain ftp.

Also, changing my infra due to nextcloud regressions is the last thing to dream on, to be frank...

@martadinata666
Copy link

martadinata666 commented Feb 20, 2024

The right question is why we can't just add the module back? It is not like the FTP option was removed from nextcloud, but the FTP module that not included by default from the upstream image. Samba module also had the same treatment for years.

@joshtrichards
Copy link
Member

I vote for adding it back directly in our images, primarily since it's a sudden regression (that no one expected).

My feelings these days about the old FTP protocol though are merely nostalgic though so I don't have a test environment for this.

Does one of you that has tested the Dockerfile adjustment (based on the one here and drawn from the steps in docker-library/php#1482) feel up to submitting a PR?

J0WI added a commit to J0WI/docker-nextcloud that referenced this issue Mar 1, 2024
J0WI added a commit to J0WI/docker-nextcloud that referenced this issue Mar 1, 2024
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
J0WI added a commit to J0WI/docker-nextcloud that referenced this issue Mar 1, 2024
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
J0WI added a commit to J0WI/docker-nextcloud that referenced this issue Mar 4, 2024
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
J0WI added a commit that referenced this issue Mar 4, 2024
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
@J0WI J0WI closed this as completed Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants