-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Run phpunit test one times more on error #687
Conversation
1fee2ef
to
047a8d1
Compare
e131f77
to
8c36a6f
Compare
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
e272e9a
to
af82260
Compare
3a842e9
to
21fdd9a
Compare
21fdd9a
to
96ae684
Compare
if [ "${{matrix.phpVersion}}" -eq 8 ]; then | ||
make phpunitforphp8.0 | ||
if [ "${{ matrix.phpVersion }}" -eq 8 ]; then | ||
make phpunitforphp8.0 || (echo "First attempt failed. Retrying PHPUnit tests..." && make phpunitforphp8.0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make phpunitforphp8.0 || (echo "First attempt failed. Retrying PHPUnit tests..." && make phpunitforphp8.0) | |
make phpunitforphp8.0 || (echo "First attempt failed. Retrying PHPUnit tests..." && make phpunitforphp8.0) |
If the command before this ||
fails, the command after this pipe ||
will be executed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are gonna retry the unit test only once when some flaky unit test fails then this method would be good instead of creating a separate step using other Github actions 👍
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
96ae684
to
935a27f
Compare
PHP Code CoverageCoverage after merging CI/ErrorMockserverNotServered into master will be
Coverage Report
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
* retry on the phpunit error for ci Signed-off-by: nabim777 <nabinalemagar019@gmail.com> * use pipeline for retry Signed-off-by: nabim777 <nabinalemagar019@gmail.com> --------- Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
* Drop support for nc 26 (#689) * Adjust or remove code specific to NC-26 Signed-off-by: Sagar <sagargurung1001@gmail.com> * Adjust or remove things realted to stable 26 Signed-off-by: Sagar <sagargurung1001@gmail.com> * fix CI failure Signed-off-by: Sagar <sagargurung1001@gmail.com> * update changelog Signed-off-by: Sagar <sagargurung1001@gmail.com> --------- Signed-off-by: Sagar <sagargurung1001@gmail.com> * Remove version comparision for secret encryption (#695) * Remove version comparision for secret encryption Signed-off-by: Sagar <sagargurung1001@gmail.com> * stlye fix Signed-off-by: Sagar <sagargurung1001@gmail.com> --------- Signed-off-by: Sagar <sagargurung1001@gmail.com> * [WP#56328]Fix error message when upload is restricted by file access control in `Nextcloud` (#688) (#696) * Fix the misleading error message when upload is restricted by file access control app * Added php unit test * update change log --------- Signed-off-by: Sagar <sagargurung1001@gmail.com> Signed-off-by: nabim777 <nabinalemagar019@gmail.com> Co-authored-by: Sagar Gurung <46086950+SagarGi@users.noreply.github.com> * [WP#57654]switch encryption for oauth secret (#694) * ci: Reduce testing matrix Signed-off-by: Joas Schilling <coding@schilljs.com> * CI: Run phpunit test one times more on error (#687) * retry on the phpunit error for ci Signed-off-by: nabim777 <nabinalemagar019@gmail.com> * use pipeline for retry Signed-off-by: nabim777 <nabinalemagar019@gmail.com> --------- Signed-off-by: nabim777 <nabinalemagar019@gmail.com> --------- Signed-off-by: Sagar <sagargurung1001@gmail.com> Signed-off-by: nabim777 <nabinalemagar019@gmail.com> Signed-off-by: Joas Schilling <coding@schilljs.com> Co-authored-by: Nalem7 <61624650+nabim777@users.noreply.github.com> Co-authored-by: Joas Schilling <coding@schilljs.com> Co-authored-by: Artur Neumann <artur@jankaritech.com>
Description
On CI, there was a flaky error in the PHPUnit test related to the mock server port. So In this PR, there is code added for CI to re-run the phpunit test one time whenever there is an error araised.
Error:
Related Issue or Workpackage
Screenshots (if appropriate):
Types of changes
Checklist:
CHANGELOG.md
file