Skip to content

Commit

Permalink
fix bug using php template for warning message
Browse files Browse the repository at this point in the history
Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
  • Loading branch information
devlinjunker committed Oct 16, 2023
1 parent b002ba6 commit a240528
Show file tree
Hide file tree
Showing 4 changed files with 26 additions and 64 deletions.
16 changes: 16 additions & 0 deletions src/App.vue
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,16 @@
<div v-if="app.error" id="warning-box">
<div>
{{ app.error }}

<ul v-for="link of app.error.links" :key="link.url">
<li>
<a :href="link.url"
target="_blank"
rel="noreferrer">
{{ link.text }}
</a>
</li>
</ul>
</div>
<div>
<span style="cursor: pointer;padding: 10px;font-weight: bold;" @click="removeError()">X</span>
Expand Down Expand Up @@ -104,6 +114,12 @@ export default Vue.extend({
display: flex;
}
#warning-box a {
color: #3a84e4;
text-decoration: underline;
font-size: small;
}
.route-container {
height: 100%;
}
Expand Down
2 changes: 1 addition & 1 deletion src/components/feed-display/FeedItemRow.vue
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,6 @@ export default Vue.extend({
}
.feed-item-row .button-container .eye-check-icon {
color: var(--color-primary-light);
color: var(--color-placeholder-dark);
}
</style>
6 changes: 4 additions & 2 deletions src/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ Vue.config.errorHandler = handleErrors
export default new Vue({
router,
store,
el: '#q-app',
el: '#content',
render: (h) => h(App),
})

Expand All @@ -51,4 +51,6 @@ export default new Vue({
function closeCronWarning() {
document.getElementById('cron-warning').style.display = 'none'
}
document.getElementById('close-cron-warning').onclick = closeCronWarning
// document.getElementById('close-cron-warning').onclick = closeCronWarning

window.store = store
66 changes: 5 additions & 61 deletions templates/part.content.warnings.php
Original file line number Diff line number Diff line change
@@ -1,62 +1,6 @@
<?php if ($_['warnings']['improperlyConfiguredCron']) { ?>
<style>
#cron-warning {
position: absolute;
right: 30px;
top: 120px;
z-index: 5;
padding: 5px;
background-color: var(--color-main-background);
color: var(--color-main-text);
box-shadow: 0 0 6px 0 var(--color-box-shadow);
border-radius: var(--border-radius);
display: flex;
max-width: 85%
}

#cron-warning a {
color: #3a84e4;
text-decoration: underline;
font-size: small;
}

#close-cron-warning {
padding: 10px;
font-weight: bold;
cursor: pointer;
}

#content {
margin-top: 0px;
}
</style>

<div id="cron-warning">
<div style="<?= $_['nc_major_version'] >= 25 ? 'padding: 12px;' : ''; ?>">
<p><?php p($l->t('Ajax or webcron mode detected! Your feeds will not be updated!')); ?></p>
<ul>
<li>
<a href="https://docs.nextcloud.org/server/latest/admin_manual/configuration_server/background_jobs_configuration.html#cron"
target="_blank"
rel="noreferrer">
<?php
p($l->t('How to set up the operating system cron'));
?>
</a>
</li>
<li>
<a href="https://github.com/nextcloud/news-updater"
target="_blank"
rel="noreferrer">
<?php
p($l->t('Install and set up a faster parallel updater that uses the News app\'s update API'));
?>
</a>
</li>
</ul>
</div>
<div>
<span id="close-cron-warning">X</span>
</div>
</div>
<?php if ($_['warnings']['improperlyConfiguredCron']) {

script('news', 'test')
?>
<div></div>
<?php }; ?>

0 comments on commit a240528

Please sign in to comment.