Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue Rewrite] Single Feed Route using FeedItemDisplayList component #2339

Merged
merged 2 commits into from
Aug 28, 2023

Conversation

devlinjunker
Copy link
Contributor

@devlinjunker devlinjunker commented Aug 27, 2023

Related to #748

Follows #2333

🗒️ Summary

Added another new route and component for displaying all items in a single feed, reusing the FeedItemDisplayList component

  • Feed Id is displayed in the URL bar and can be loaded from there
  • Title Unread count is shown at the top of the page
  • Seems there is a bug I need to work out with fetching all items, and determining when to stop fetching (i.e "reached the end" of the scroll list)
  • Moved all route based components to subdirectory routes

Added Filters to FeedItemDisplayList component

  • For filtering starred/unread items in a list of items
  • Added config to FeedItemDisplayList to disable these (e.g. disable star filter on starred route, and unread filter on unread route)

✅ Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
    - [ ] Changelog entry added for all important changes. (Can we add the skip-changelog label to prevent the check for changelog? )

📷 Visual

single feed route:
Aug-26-2023 22-40-04

loading feed based on url param:
Aug-26-2023 22-44-54

filter:
filters

➡️ Up Next

  • Fix bug in fetching items
  • Create feed-display/ directory and move all Feed... components into it (also create internal/ subdir that holds VirtualScroll and ItemSkeleton)
  • Reuse VirtualScroll component for:
    • display items in a folder
    • display all items in database
  • (WIP) Move API Requests to Service Classes (to be shared between stores and prevent stuff like having to duplicate api requests like here…)
  • Sidebar Actions (WIP)
  • use ?selected=<id> url query parameter to store and parse which Feed Item is displayed in FeedItemDisplay
  • Quick access to Settings
  • Update Documentation
  • Mobile friendly layout

Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
@Grotax Grotax added frontend impact Javascript/Frontend code Skip-Changelog No changelog update is required, minor change labels Aug 27, 2023
@Grotax Grotax merged commit 83f99de into nextcloud:vue-rewrite Aug 28, 2023
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend impact Javascript/Frontend code Skip-Changelog No changelog update is required, minor change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants