Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue Rewrite] Share Article Component #2361

Merged
merged 6 commits into from
Oct 4, 2023

Conversation

devlinjunker
Copy link
Contributor

@devlinjunker devlinjunker commented Sep 26, 2023

Related to #748

Follows #2360

πŸ—’οΈ Summary

  • Add Share Item Component for sharing articles

βœ… Checklist

- [ ] Changelog entry added for all important changes. (Can we add the skip-changelog label to prevent the check for changelog? )

πŸ“· Visual

Share Component:
sharing

Appearing when Shared User logs in:
Screenshot 2023-09-26 at 3 59 58 PM

➑️ Up Next

MVP:

  • Audio/Video Feed Items
  • Error Messages (on backend request failure)
  • Mobile friendly layout (since we are no longer displaying the feed item below the row)
  • Settings in Sidebar
    • Keyboard Navigation
    • Mark on Scroll
    • Reverse Order (Oldest to Newest)
    • Upload/Download Subscriptions/Articles
  • Fix Explore Page
  • use ?selected=<id> url query parameter to store and parse which Feed Item is displayed in FeedItemDisplay (this will be useful for implementing the search bar - and allow navigating directly to the specific feed item)
    • Also need to update search provider php code
  • Update Documentation for Front End
    • Developer
      • Frontend Tips/Organization
      • Front End Unit Tests
    • Sharing
    • Remove Frontend/JS Plugin Documentation

Following Rewrite Release Improvements:

  • addArticleAction Plugin API
    • Nextcloud News Code
    • Add to Bookmarks Example Plugin
    • Update Documentation
  • Additional Views (Compact/Expanded etc)

Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
@Grotax Grotax added the Skip-Changelog No changelog update is required, minor change label Sep 27, 2023
@Grotax
Copy link
Member

Grotax commented Oct 1, 2023

Because of the merge there is a conflict in this PR now.

Great work so far, watching the progress you make is nice.
And I think we are getting very close to a merge into master (which will be tricky I'm sure :D)

Signed-off-by: devlinjunker <devlin.junker@gmail.com>
@devlinjunker
Copy link
Contributor Author

devlinjunker commented Oct 1, 2023

Fixed the conflict!

Thanks! It has been satisfying, hopefully it will be easier to maintain and contribute to now... and I agree we're almost ready for a release! Most important to do still is make sure it works well on mobile, as that's how I scroll through the feeds on my instance usually πŸ˜„

I am going to try to wrap up all of the tasks listed in the Up Next section in the next few weeks though if I can

@devlinjunker devlinjunker mentioned this pull request Oct 2, 2023
8 tasks
Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
@devlinjunker
Copy link
Contributor Author

I think I fixed the static analysis PHPCS error on this branch, once the workflows re-run and have (hopefully) passed can we merge this in?

@devlinjunker
Copy link
Contributor Author

failing checks are related to the dbal dependency, so just merging this

@devlinjunker devlinjunker merged commit bcb3dcb into nextcloud:vue-rewrite Oct 4, 2023
16 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip-Changelog No changelog update is required, minor change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants