Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wording consistency with other Nextcloud apps #2711

Closed
wants to merge 1 commit into from

Conversation

Jerome-Herbinet
Copy link
Member

Signed-off-by: Jérôme Herbinet 33763786+Jerome-Herbinet@users.noreply.github.com

Wording consistency with other Nextcloud apps because in other Nextcloud apps, the settings button's wording is :

"{name of the app} settings"

  • Resolves: #

Summary

Checklist

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
@Grotax
Copy link
Member

Grotax commented Jul 8, 2024

Hi we can merge this but this file is actually no longer in use it's left over due to UI migration.

@Jerome-Herbinet
Copy link
Member Author

Jerome-Herbinet commented Jul 9, 2024

Hi we can merge this but this file is actually no longer in use it's left over due to UI migration.

@Grotax I figured someone would say that... and it makes sense, but can someone help me find where the wording actually is?

@Grotax
Copy link
Member

Grotax commented Aug 17, 2024

I'm not sure :)

But first, we are talking about the Nextcloud Admin Settings right?
There the entry in the left menu and the title of the News settings is actually just News now.

<NcSettingsSection :title="t('news', 'News')"

@Jerome-Herbinet
Copy link
Member Author

I'm not sure :)

But first, we are talking about the Nextcloud Admin Settings right? There the entry in the left menu and the title of the News settings is actually just News now.

<NcSettingsSection :title="t('news', 'News')"

@Grotax not exactly, I'm talking about the “settings” button in the bottom left corner.
2024-08-19_11-48

@Grotax
Copy link
Member

Grotax commented Aug 19, 2024

Ah these user settings dont exist at this moment. Not re-implemented :)

But we can check in the future that it will be News Settings

@Jerome-Herbinet
Copy link
Member Author

Ah these user settings dont exist at this moment. Not re-implemented :)

But we can check in the future that it will be News Settings

@Grotax thanks for the information. I guess that I now have to close this PR ?

@Grotax Grotax closed this Aug 19, 2024
@Jerome-Herbinet Jerome-Herbinet deleted the Jerome-Herbinet-patch-1 branch August 20, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants