Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration to allow feed title to be null #2745

Merged
merged 1 commit into from
Aug 18, 2024
Merged

Add migration to allow feed title to be null #2745

merged 1 commit into from
Aug 18, 2024

Conversation

Grotax
Copy link
Member

@Grotax Grotax commented Aug 17, 2024

Summary

Allow feed title to be null in DB. Nothing we can do in the backend when there is no title.

Checklist

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
@anoymouserver
Copy link
Contributor

Wouldn't this cause empty entries in the sidebar for the affected feeds?
Maybe a fallback to the feeds domain would be better than allowing null in the database..

if (!is_null($title)) {
$feed->setTitle($title);
}

@Grotax
Copy link
Member Author

Grotax commented Aug 18, 2024

Well I'm open for PRs regarding that, I will still merge this as this should have been done when the code started to allow null for the title and pushed it to the DB.

@Grotax Grotax merged commit ca56bfb into master Aug 18, 2024
22 of 23 checks passed
Grotax added a commit that referenced this pull request Oct 3, 2024
Fixed
- Use updated user agent when fetching feeds and favicons (#2788)
- Allow feed title to be null in DB. (#2745)
- Store HTTP last modified date from response header (#2724)
- Admin settings could not be saved (#2533)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Grotax added a commit that referenced this pull request Oct 3, 2024
Fixed
- Use updated user agent when fetching feeds and favicons (#2788)
- Allow feed title to be null in DB. (#2745)
- Store HTTP last modified date from response header (#2724)
- Admin settings could not be saved (#2533)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Grotax added a commit that referenced this pull request Oct 3, 2024
Fixed
- Use updated user agent when fetching feeds and favicons (#2788)
- Allow feed title to be null in DB. (#2745)
- Store HTTP last modified date from response header (#2724)
- Admin settings could not be saved (#2533)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
@Grotax Grotax mentioned this pull request Oct 3, 2024
Grotax added a commit that referenced this pull request Oct 4, 2024
Fixed
- Use updated user agent when fetching feeds and favicons (#2788)
- Allow feed title to be null in DB. (#2745)
- Store HTTP last modified date from response header (#2724)
- Admin settings could not be saved (#2533)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants