Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NC16 is php >= 7.1 #13122

Merged
merged 2 commits into from
Dec 21, 2018
Merged

NC16 is php >= 7.1 #13122

merged 2 commits into from
Dec 21, 2018

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Dec 17, 2018

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

@rullzer rullzer added 3. to review Waiting for reviews technical debt labels Dec 17, 2018
@rullzer rullzer added this to the Nextcloud 16 milestone Dec 17, 2018
ChristophWurst
ChristophWurst approved these changes Dec 17, 2018
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@rullzer rullzer added 4. to release Ready to be released and/or waiting for tests to finish 2. developing Work in progress and removed 3. to review Waiting for reviews 4. to release Ready to be released and/or waiting for tests to finish labels Dec 17, 2018
@rullzer
Copy link
Member Author

rullzer commented Dec 17, 2018

Well. This requires of course all the CI containers of php7 to be upgraded

@skjnldsv skjnldsv added the pending documentation This pull request needs an associated documentation update label Dec 18, 2018
@skjnldsv
Copy link
Member

We'll have to update the docs as well :)

@tcitworld
Copy link
Member

Oh yeah, finally we can use PHPUnit 7!

@rullzer
NC16 is php >= 7.1
3a6e739 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer
Fix drone images
70936dc 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer merged commit 58d4b8e into master Dec 21, 2018
@rullzer rullzer deleted the td/min_php_bump branch December 21, 2018 15:53
@rullzer rullzer mentioned this pull request Jan 3, 2019
Closed
1 task
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Jan 7, 2019
@skjnldsv skjnldsv removed the pending documentation This pull request needs an associated documentation update label Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@schiessle schiessle Awaiting requested review from schiessle

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

@kesselb kesselb Awaiting requested review from kesselb

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish technical debt
Projects
None yet
Milestone
Nextcloud 16
Development

Successfully merging this pull request may close these issues.
5 participants
@rullzer @skjnldsv @tcitworld @nickvergessen @ChristophWurst