Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix pi-hole script #2612

Merged
merged 1 commit into from
Jan 24, 2024
Merged

fix pi-hole script #2612

merged 1 commit into from
Jan 24, 2024

Conversation

szaimen
Copy link
Collaborator

@szaimen szaimen commented Jan 24, 2024

No description provided.

@szaimen
fix pi-hole script
e040749 
Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen szaimen marked this pull request as ready for review January 24, 2024 20:57
szaimen
szaimen commented Jan 24, 2024
View reviewed changes
not-supported/pi-hole.sh
@@ -192,6 +192,9 @@ sed -i "s|getStaticIPv4Settings$|echo getStaticIPv4Settings|" "$SCRIPTS"/pihole-
PIHOLE_INTERFACE="$IFACE"
export PIHOLE_INTERFACE

# Fix php versions getting hold for pi-hole install script
apt-mark unhold php"$PHPVER"*
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@enoch85 maybe we should add this line also below here?

vm/nextcloud_update.sh

Line 350 in 3149aad

apt-mark hold php* >/dev/null 2>&1

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise the php8.1 packages are never going to be upgraded...

@enoch85 enoch85 merged commit bf37233 into master Jan 24, 2024
7 checks passed
@delete-merged-branch delete-merged-branch bot deleted the enh/noid/fix-pi-hole-script branch January 24, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
3. to review bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szaimen @enoch85