export v2: footer description option #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows users to point to a Markdown file that contains description to display in the Auspice footer.
jameshadfield
requested changes
Dec 12, 2019
There was a problem hiding this comment.
This looks good @joverlee521, thanks! Please add a test build (e.g. fa98bb2 or similar) which uses a custom description/footer.
|
Can we update the documentation/migration guide as well? I suppose it's not officially part of v6 perhaps but this is the best description of all the export options we have, and even I find it useful as there are lots to remember...! |
Raise fatal error if the provided description file does not exist.
tsibley
requested changes
Dec 12, 2019
joverlee521
force-pushed
the
export-footer
branch
from
83de9aa
to
c8038db
Compare
This was referenced Dec 12, 2019
jameshadfield
approved these changes
Dec 12, 2019
kairstenfay
approved these changes
Dec 13, 2019
trvrb
requested changes
Dec 13, 2019
There was a problem hiding this comment.
I accidentally typed in review of nextstrain/auspice#834 here.
trvrb
approved these changes
Dec 13, 2019
tsibley
approved these changes
Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
export v2add a--descriptionoption that takes a Markdown file and adds the text to the JSON inmeta.description.This PR is dependent on nextstrain/auspice#834 to render the footer text in Auspice.