Skip to content

Commit

Permalink
Update webpack output names
Browse files Browse the repository at this point in the history
Context: in webpack v5, the files associated with the "core-vendors"
custom group are classified as initial (entry-point) chunk files [1]
when that was not the case in webpack v4. Not sure why.

Add [name] to filename to be more consistent with chunkFilename, and so
it's easier to understand the association between files and cacheGroups.

Update the bundlesize config glob patterns to match these new names.
Since the exact reason for filename vs. chunkFilename isn't clear to me,
I updated all glob patterns to match either.

[1]: https://webpack.js.org/configuration/output/#outputchunkfilename
  • Loading branch information
victorlin committed Oct 4, 2022
1 parent 66fac38 commit d44b47d
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
10 changes: 5 additions & 5 deletions bundlesize.config.json
Original file line number Diff line number Diff line change
@@ -1,23 +1,23 @@
{
"files": [
{
"path": "./dist/auspice.bundle.*.js",
"path": "./dist/auspice.main.bundle.*.js",
"maxSize": "2 kB"
},
{
"path": "./dist/auspice.chunk.+([0-9]).bundle.*.js",
"path": "./dist/auspice.?(chunk.)+([0-9]).bundle.*.js",
"maxSize": "100 kB"
},
{
"path": "./dist/auspice.chunk.core-vendors.bundle.*.js",
"path": "./dist/auspice.?(chunk.)core-vendors.bundle.*.js",
"maxSize": "220 kB"
},
{
"path": "./dist/auspice.chunk.other-vendors.bundle.*.js",
"path": "./dist/auspice.?(chunk.)other-vendors.bundle.*.js",
"maxSize": "150 kB"
},
{
"path": "./dist/auspice.chunk.locales.bundle.*.js",
"path": "./dist/auspice.?(chunk.)locales.bundle.*.js",
"maxSize": "100 kB"
}
]
Expand Down
2 changes: 1 addition & 1 deletion webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ const generateConfig = ({extensionPath, devMode=false, customOutputPath, analyze
entry,
output: {
path: outputPath,
filename: `auspice.bundle${!devMode ? ".[contenthash]" : ""}.js`,
filename: `auspice.[name].bundle${!devMode ? ".[contenthash]" : ""}.js`,
chunkFilename: `auspice.chunk.[name].bundle${!devMode ? ".[chunkhash]" : ""}.js`,
publicPath: "/dist/"
},
Expand Down

0 comments on commit d44b47d

Please sign in to comment.