Split view broken #574
Comments
|
Thanks @colinmegill. This is almost certainly an issue with the scrollbar width we're using. I tuned it off Mac where they are thinner. |
|
Hmm... I've got the same problem on Mac - do you repro there?
…On Mon, Jun 4, 2018 at 2:08 PM Trevor Bedford ***@***.***> wrote:
Thanks @colinmegill <https://github.com/colinmegill>. This is almost
certainly an issue with the scrollbar width we're using. I turned it off
Mac where they are thinner.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#574 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABsDGYT2Nx2rKbYrgExHLChzL2vmRyjrks5t5XekgaJpZM4UZiAg>
.
|
|
Mac / Chrome is working fine for me. Haven't encountered this issue. Works at all window sizes and browser-zoom levels.
|
|
Interesting! It looks like you do have your scrollbar turned off there, are you able to turn it back on? |
|
This still happens periodically on different browsers / OSs. |
|
Same
…On Sun, Jul 29, 2018, 1:48 PM james hadfield ***@***.***> wrote:
This still happens periodically on different browsers / OSs.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#574 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABsDGXop_CaIqpBT9h-NQhEpPfkSnottks5uLfVegaJpZM4UZiAg>
.
|
|
|
Windows 10 Pro:
|
|
@rneher / @emmahodcroft could you change this line https://github.com/nextstrain/auspice/blob/master/src/util/computeResponsive.js#L28 and see if you can fix it? Perhaps there's a fundamentally different (and better) way of calculating this. |
|
if I change it to 100, it works on linux/chrome and firefox. reducing it to 56 breaks it on linux/firefox. status quo works for firefox, not chrome |
|
this surely has to do with all the different paddings that are added here and there. I don't see why we need to get this right to the pixel. I don't think it matters if there are 30px of white space on the right. |
|
The right thing to do here is probably to measure the size of the
container. https://www.npmjs.com/package/react-measure or another similar
package, or a custom implementation based off of them (they aren't
complicated) and base the subsequent computations off of that.
…On Mon, Jul 30, 2018 at 1:33 PM Richard Neher ***@***.***> wrote:
this surely has to do with all the different paddings that are added here
and there. I don't see why we need to get this right to the pixel. I don't
think it matters if there are 30px of white space on the right.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#574 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABsDGfei2LWCGTQBSbJX9zpVl4WJz66tks5uL0N6gaJpZM4UZiAg>
.
|
|
Given the reason for existence cited in the code James pointed at, I wonder if using appropriate |
|
I think i'll change the value to ~100px so that it's not broken now for people. Going forward, something like |
|
Please reopen if it's still broken on v1.23.2. |
|
This is fixed here on windows and looks beautiful. It's a fine solution,
especially now that cards are gone.
…On Mon, Jul 30, 2018 at 6:42 PM james hadfield ***@***.***> wrote:
Please reopen if it's still broken on v1.23.2.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#574 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABsDGQfuh_rW9D57L02_l26HgFUu9tHEks5uL4vhgaJpZM4UZiAg>
.
|
|
Works on Windows 10 Chrome, Firefox, IE, Edge 👍 |
Chrome, PC
The text was updated successfully, but these errors were encountered: