Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Unassigned" colors are displaying as purple rather than gray #593

Closed
trvrb opened this issue Jul 9, 2018 · 1 comment
Closed

"Unassigned" colors are displaying as purple rather than gray #593

trvrb opened this issue Jul 9, 2018 · 1 comment

Comments

@trvrb
Copy link
Member

trvrb commented Jul 9, 2018

Here is live https://nextstrain.org/flu/seasonal/h3n2/na/2y with coloring by "clade":

unassigned

All the internal nodes are unassigned as appropriate. However, the color scheme does not have an "Unassigned" box and these nodes are purple rather than gray. This might be because the iteration when creating color scheme is through tips rather than through nodes, but this is just a guess.
jameshadfield added a commit that referenced this issue Jul 9, 2018
@jameshadfield
Merge branch '593'
ea46761 
* 593:
  Scan internal nodes for attr values. Closes #593
@trvrb
Copy link
Member Author

trvrb commented Jul 9, 2018

This looks great. Thanks @jameshadfield.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@trvrb