Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPM_TOKEN not defined #661

Closed
trvrb opened this issue Sep 7, 2018 · 2 comments
Closed

NPM_TOKEN not defined #661

trvrb opened this issue Sep 7, 2018 · 2 comments
Assignees
@tsibley @jameshadfield
Labels
bug Something isn't working

Comments

@trvrb
Copy link
Member

trvrb commented Sep 7, 2018

Bug that I just introduced, when running npm start, or anything really the value of NPM_TOKEN that's specified here https://github.com/nextstrain/auspice/blob/master/.npmrc is not defined. This causes the following error:

Leda:auspice trvrb$ npm start
Error: Failed to replace env in config: ${NPM_TOKEN}
    at /usr/local/lib/node_modules/npm/lib/config/core.js:415:13

Maybe there's a simple way to define a fall back in the .npmrc file? Sorry about this.
@trvrb trvrb added the bug Something isn't working label Sep 7, 2018
tsibley added a commit that referenced this issue Sep 7, 2018
@tsibley
Remove .npmrc file
c4e2001 
It broke local use of npm if NPM_TOKEN was missing from the environment.
Since the file was only meant for Travis CI, define the config
dynamically in .travis.yml instead.

Resolves #661.
@tsibley tsibley mentioned this issue Sep 7, 2018
Merged
@tsibley
Copy link
Member

tsibley commented Sep 7, 2018

@trvrb I believe PR #662 will fix it. It is untested because it requires pushing to release to test.

@tsibley
Copy link
Member

tsibley commented Sep 7, 2018

I made a new release, 1.30.2, to test that my fix works. It does!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsibley tsibley

@jameshadfield jameshadfield

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tsibley @trvrb @jameshadfield