Function 'getMinMaxFromTree' defined at line 15 takes 3 arguments, bu… #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
In src/util/colorScale.js, the function 'getMinMaxFromTree' defined at line 15 takes 3 arguments, but it was called with 4 arguments at two places.
Description of proposed changes
What is the goal of this pull request? What does this pull request change?
This trivial change fixes some invalid JavaScript. The problem was harmless (other than code readability) so please feel free to ignore this PR.
Related issue(s)
Fixes #
Related to #
Testing
What steps should be taken to test the changes you've proposed?
If you added or changed behavior in the codebase, did you update the tests, or do you need help with this?
Yes, I would like help with testing. I ran my linter program to check the syntax and calling semantics. Please feel free to ignore this PR due to a lack of testing.
Thanks -- Rick
Thank you for contributing to Nextstrain!