Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added application/json content-type to v2 dataset responses #1080

Merged
merged 1 commit into from
Apr 22, 2020

Conversation

ericenns
Copy link
Contributor

@ericenns ericenns commented Apr 21, 2020

Description of proposed changes

What is the goal of this pull request? What does this pull request change?

This adds the application/json content-type to v2 dataset responses, which allows a proxy server to compress datasets when sending them to the client.

Related issue(s)

Fixes #
Related to #

Testing

What steps should be taken to test the changes you've proposed?
If you added or changed behavior in the codebase, did you update the tests, or do you need help with this?

Thank you for contributing to Nextstrain!

Copy link
Member

@jameshadfield jameshadfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! (We used to have this when we used res.json but was lost when we moved to streamed responses.)

@jameshadfield jameshadfield merged commit cef3a2a into nextstrain:master Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants