Cast all branch labels to strings #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses a long-standing bug in auspice and closes #888. Casting branch labels to strings doesn't change how the labels render, but does allow restoration of zoom state via URL queries which always use strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a long-standing bug in auspice and closes #888. Casting branch labels to strings doesn't change how the labels render, but does allow restoration of zoom state via URL queries which always use strings.
Testing
Compare the behavior of this PR vs nextstrain.org for the flu/seasonal/h1n1pdm/ha/12y dataset which has numeric branch label values.
Additionally to this, as per #888 (comment), the augur schema should be updated to indicate that string label values should be used.