Remove scrollbar in PanelsContainer when no scrolling is possible #1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change `overflow-y` from `scroll` to `auto` to hide the scroll bar when not needed.
|
Scrollbars are something that I'd like to improve in Auspice - they are automagically hidden on MacOS by default which is where I do most of my development. I've tested this change (by restricting the panels to "entropy" only and also using narratives, as well as reading these docs) and can't find any regressions with it, so thankyou @artt! It's also a good reminder to me to fix the scroll bars in a couple of other places. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Removes scrollbar in the
PanelsContainercomponent when the window's height is enough to show the entire content.Related issue(s)
Fixes #1438
Testing
Build from this fork, go to
/ncov/gisaid/global?branchLabel=none&c=GISAID_clade&d=tree&p=full&sidebar=closedwith adequate window height (> 700px should be fine) and the scrollbar should be hidden. The scrollbar should be shown when scrolling is needed.