Regression line only considers visible nodes #1484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the PhyloTree logic to call the recalculate & redraw functions each time the visibility changes. Note that the regression calculation does not yet take account of the visible nodes so there should be no functionality changes in this commit.
Changes the regression calculations to only consider visible nodes. Closes #1483 Note this has the (rare but strange) UI situation where we have zero visible tips, and thus the regression line isn't drawn, but the sidebar toggle still indicates that the regression is "on".
|
Awesome! Thanks for the quick work here James. I noticed this originally when I was attempting to explain to someone that you should still less clock correlation with a dataset that spans a narrower time window. With PR, this works as expected, where you can go from R^2 of 0.82 for the full ~2 year dataset to an R^2 of 0.33 for dataset spanning ~6 months. Really cool to be able to drag the date slider and watch the regression line update live in response. Everything seems to be working well in my testing. Nice that you catch the empty dataset edge case. |
trvrb
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1483 for context. A couple of before (left) vs after (right) screenshots: