Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tree] escape key dismisses any info modal #1485

Merged
merged 1 commit into from
Mar 17, 2022
Merged

[tree] escape key dismisses any info modal #1485

merged 1 commit into from
Mar 17, 2022

Commits on Mar 17, 2022

  1. [tree] escape key dismisses any info modal 

    This implements what we think is an intuitive UI, and also helps with
the bug described in #1243 where removing/disabling a strain-filter
results in the tree visualisation falling out-of-sync with the modal.

Note that `event.key` may not be implemented in all browsers, however
this functionality is a nicety rather than a must-have, so this is
tolerable. Thanks to @joverlee521 for suggesting to use this instead of
`event.keyCode` during PR review.

See #1479 for context.

Closes #1479
    @jameshadfield
    jameshadfield committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    25e5906 View commit details
    Browse the repository at this point in the history