Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap to "experimental" icon for exploded trees sidebar option #1486

Merged
merged 3 commits into from
Mar 27, 2022

Conversation

trvrb
Copy link
Member

@trvrb trvrb commented Mar 16, 2022

Description of proposed changes

This swaps the previous use of "[experimental]" in the "Explode tree by" sidebar option to a cleaner looking icon. I chose a wrench, thinking that this best represents work in progress.

Screen Shot 2022-03-16 at 1 58 59 PM

Testing

I've tested locally, but it should be a small enough change that it should be safe.

This swaps the previous use of "[experimental]" to a cleaner looking icon. I chose a wrench, thinking that this best represents work in progress.
@nextstrain-bot nextstrain-bot temporarily deployed to auspice-experimental-ic-kdgexq March 16, 2022 20:53 Inactive
@jameshadfield
Copy link
Member

Happy to have an icon here, but for me the wrench doesn't convey "experimental", how about one of:

<GiStandingPotion/>
image

<AiTwotoneExperiment/>
image

<ImLab/>
image

Also, we should have some text pop up on-hover - I can add a commit for this shortly.

@trvrb
Copy link
Member Author

trvrb commented Mar 17, 2022

Thanks James! I understand that the wrench isn't conveying "experimental" to you. I guess I was thinking of it most as "in progress" or "under construction". I'm having a bit of difficulty with the beaker as it conveys "science" to me rather than "experimental". But that said, after looking a bit I don't have a better suggestion. Out of the three <ImLab/> would seem to work best at small font size.

For tooltip, I'd think to just use the regular FaInfoCircle on the right hand side of the sidebar and note in the tooltip the "Experimental:" warning.

@jameshadfield
Copy link
Member

Changed to the following, which I prefer, but either icon is preferable to the current version! I'll merge shortly unless others have objections / want to move back to the wrench 😉

image

@jameshadfield
Copy link
Member

(Force pushed to fix the typo in the on-hover text.)

@trvrb trvrb temporarily deployed to auspice-experimental-ic-1qmqxd March 25, 2022 22:29 Inactive
@trvrb
Copy link
Member Author

trvrb commented Mar 25, 2022

Thanks @jameshadfield! I'm happy with the beaker, but I do have a preference here for consistency in how the explanatory tooltips behave. In the current PR, if you mouseover any of the text in "Explode Tree By" or the beaker icon you get that explanatory tooltip with "This functionality is experimental and should be treated with caution! Exploding a tree by trait X means that for each branch where the trait changes value..."

This is different from the explanatory tooltip for "Tree Options", etc... where you get nothing when you mouseover the text, but you get the tooltip when you mouseover the (i). I really like having the visual cue that you can mouseover to get explanatory text. I'd recommend either:

  1. Just a single tooltip with the existing text that appears on hover of an (i) icon on the right
  2. A "This functionality is experimental and should be treated with caution!" tooltip when mousing over the just the beaker (and not the text) and a separate "Exploding a tree by trait X means that for each branch where the trait changes value..." tooltip when mousing over an (i) icon on the right

I lean towards option 2.

This adds styled components for a "SidebarSubtitle" with an on-hover info box. As we build out more of these we may need to re-asses the exact styling if it becomes too busy.
Note that we now have a custom-styled react-select component  via PR #1482.
@jameshadfield jameshadfield temporarily deployed to auspice-experimental-ic-1qmqxd March 27, 2022 23:29 Inactive
@jameshadfield
Copy link
Member

Thanks @trvrb -- implemented option 1 as I felt people may not hover over the experimental icon. I didn't originally do this as I was worried about having too many "info" icons, but even if we built them for all of the options it's not actually too bad (and if we do get here, we can tweak the styles further):

image

@jameshadfield jameshadfield merged commit fca3511 into master Mar 27, 2022
@jameshadfield jameshadfield deleted the experimental-icon branch March 27, 2022 23:39
@trvrb
Copy link
Member Author

trvrb commented Mar 28, 2022

Looks great. Thanks James!

@tsibley
Copy link
Member

tsibley commented Apr 1, 2022

Alternative options if the beaker is too sciencey given our domain:

image
image

These speak more to construction than the beaker to me, but the beaker does mean "experimental" to me given its common use that way in other software products.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

4 participants