Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for Node.js version 12, add 18 #1560

Merged
merged 4 commits into from
Mar 7, 2023
Merged

Remove support for Node.js version 12, add 18 #1560

merged 4 commits into from
Mar 7, 2023

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented Oct 4, 2022 •
edited
Loading

Description of proposed changes

See commit messages.

Related issue(s)

Tasks

Testing

  • Ran with Node.js v18 locally and the example zika dataset seems to work fine
  • Checks pass

@victorlin victorlin self-assigned this Oct 4, 2022
@nextstrain-bot nextstrain-bot temporarily deployed to auspice-victorlin-updat-jfpodf October 4, 2022 17:56 Inactive
This was referenced Oct 4, 2022
Merged
Closed
@victorlin victorlin force-pushed the victorlin/update-node-versions branch from 99762f4 to 1ca9076 Compare March 2, 2023 20:45
@victorlin victorlin force-pushed the victorlin/update-node-versions branch from 1ca9076 to 402828c Compare March 2, 2023 21:04
@victorlin
Add support for NPM version 9
62de588 
NPM version 9, release 2022-10-19, comes with several changes¹. None of
the breaking changes seem to be relevant for usage with Auspice.

¹ https://github.com/npm/cli/releases/tag/v9.0.0
@victorlin
Update changelog
8a47d3c
@victorlin victorlin marked this pull request as ready for review March 2, 2023 23:43
@victorlin victorlin requested a review from a team March 2, 2023 23:43
tsibley
tsibley approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@tsibley tsibley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me by inspection.

jameshadfield
jameshadfield approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@jameshadfield jameshadfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me by inspection.

Same for me!

@victorlin victorlin merged commit 0b5163a into master Mar 7, 2023
@victorlin victorlin deleted the victorlin/update-node-versions branch March 7, 2023 17:43
@victorlin victorlin mentioned this pull request Mar 7, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsibley tsibley tsibley approved these changes

@jameshadfield jameshadfield jameshadfield approved these changes

Assignees

@victorlin victorlin

Labels
None yet
Projects
No open projects
Nextstrain planning (archived)
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update supported node versions
4 participants
@victorlin @tsibley @jameshadfield @nextstrain-bot