Align first major grid circle in radial view #1693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When plotting the first major grid, its position value can be below the domain of the x-axis. I'm not sure why. To reduce the effects of this, impose a lower limit on grid positions. Previously, these situations would render a first major grid circle offset from the center. With this change, it draws a point at the actual center. The text labels are similarly adjusted.
nextstrain-bot
temporarily deployed
to
auspice-victorlin-fix-r-st5x6f
|
Closes #1384 |
jameshadfield
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compare radial tree view of Zika dataset before and after.
Description of proposed changes
When plotting the first major grid, its position value can be below the domain of the x-axis. I'm not sure why. To reduce the effects of this, impose a lower limit on grid positions.
Previously, these situations would render a first major grid circle offset from the center. With this change, it draws a point at the actual center.
The text labels are similarly adjusted.
Related issue(s)
Prompted by a discussion post.
Checklist
(to be done by a Nextstrain team member) Create preview PRs on downstream repositories.I don't think this is necessary.