Create PRs on other repos with GitHub CLI #1765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorlin
force-pushed
the
victorlin/update-make_pr_for_downstream_repo
branch
from
16b993f
to
9a43f17
Compare
This was referenced Apr 10, 2024
victorlin
force-pushed
the
victorlin/update-make_pr_for_downstream_repo
branch
from
fc4417f
to
f3de41f
Compare
Removes the warnings from the workflow summary page. <https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/>
Job summaries are more visible than log messages from a step.
victorlin
force-pushed
the
victorlin/update-make_pr_for_downstream_repo
branch
from
c510792
to
1fcc625
Compare
victorlin
force-pushed
the
victorlin/update-make_pr_for_downstream_repo
branch
from
1fcc625
to
8505757
Compare
No functional change here except removal of the PR number from the job summary (URL is more directly available and useful).
victorlin
force-pushed
the
victorlin/update-make_pr_for_downstream_repo
branch
from
8505757
to
c448302
Compare
This was referenced Apr 10, 2024
joverlee521
approved these changes
Apr 11, 2024
| @@ -81,10 +81,17 @@ jobs: | |||
| This will surface any issues that can arise from merging the PR in Auspice. To address these issues locally, update the source branch (e.g. with a git rebase). | |||
|
|
|||
| This message and corresponding commits were automatically created by a GitHub Action from [nextstrain/auspice](https://github.com/nextstrain/auspice). | |||
| draft: true | |||
| delete-branch: true | |||
There was a problem hiding this comment.
non-blocking
I don't see an equivalence for the delete-branch input, but I'm not sure we even used it as intended?
There was a problem hiding this comment.
From the action's README:
If a pull request exists and new changes on the base branch make the pull request unnecessary (i.e. there is no longer a diff between the pull request branch and the base), the pull request is automatically closed. Additionally, if
delete-branchis set totruethebranchwill be deleted.
Yeah, I don't think we actually used it - we just close the PRs and delete the branches manually, which is fine.
7 tasks
Very nice to see! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Motivation: move away from 3rd party Actions.
No functional change here except removal of the PR number from outputs (URL is more directly available and useful)
Related issue(s)
Checklist
If making user-facing changes, add a message in CHANGELOG.md summarizing the changes in this PRno functional changespeter-evans/create-pull-requestfrom allow list in GitHub org settings (it was only used in this repo)