measurements: Revert back to useMemo #1838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves lint warnings from #1837. I wonder if I ran into lint warnings the first time I tried `useCallback` which is why I ended up using `useMemo`? Noting in comments so I don't flip-flop again.
nextstrain-bot
temporarily deployed
to
auspice-measurements-li-56h8yp
|
Confirmed in the test app that the measurements x-axis still works as expected
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Resolves lint warnings from #1837.
I wonder if I ran into lint warnings the first time I tried
useCallbackwhich is why I ended up usinguseMemo? Noting in comments so I don't flip-flop again.Checklist