PhyloTree cleanup #493
Merged
PhyloTree cleanup #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has no functional changes, but cleans up the files inside
src/components/treeand improves syntax (following eslint rules).The new structure is as follows:
tree/index.js: formerlyTreeView.js. Exports the React component<Tree>, inside of which PhyloTree is rendered etctree/treeHelpers.js: functions which operate on the (redux) nodes structure.tree/infoPanels/*: the tip / branch hover info panel & the tip clicked (selected) info panel components.tree/legend/*: the legend componentstree/reactD3Interface/index.js: The logic to compare react props and decide the appropriate PhyloTree prototypes to call. Rather complex!tree/reactD3Interface/callbacks.js: the callbacks supplied to PhyloTree (e.g.onTipHover)tree/phyloTree/phyloTree.js: ExportsPhyloTree(the function used to render the tree). Note that all prototypes are set here but defined in other files for clarity.tree/phyloTree/*: files which define the prototypes used byPhyloTree