Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time slicing #638

Merged
merged 4 commits into from
Aug 25, 2018
Merged

Time slicing #638

merged 4 commits into from
Aug 25, 2018

Conversation

jameshadfield
Copy link
Member

@jameshadfield jameshadfield commented Aug 24, 2018

Watching people interact with auspice has made it apparent that branches which are not in the selection (time slice, filters etc) are confusing to people. We currently draw them thinner, but they are still there, with on-hover info boxes etc. This PR improves the visual distinction between in-selection and out-of-selection branches / tips, especially for time slices.

  • on-hover info boxes no longer appear for out-of-selection branches / tips
  • There is no longer the ability to click on out-of-selection branches (and the cursor no longer implies this ability)
  • out-of-selection branches are now thinner
  • for rectangular layouts & temporal trees there is a grey background indicating the selected time slice. This looks especially good for animations and generally improves clarity (in my opinion).
    • Note that a bunch of tips & parts-of-branches are rendered as "in-selection" but out of this grey-time-slice... this is issue tree branch visibility is incorrect #473, those tips are actually out of the current selection.

@trvrb
Copy link
Member

trvrb commented Aug 24, 2018

I think this is a significant improvement. Really nice idea.

I couldn't break anything. Please go ahead and merge.

@jameshadfield jameshadfield merged commit 6d5ab2f into master Aug 25, 2018
@jameshadfield jameshadfield deleted the time-slicing branch August 25, 2018 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants