Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display repo and maintainers as byline #821

Merged
merged 10 commits into from
Nov 26, 2019
Merged

Display repo and maintainers as byline #821

merged 10 commits into from
Nov 26, 2019

Commits on Nov 12, 2019

  1. Include byline as part of Info component

    This byline includes both repository and maintainers where available in metadata. This replaces the use of maintainers in footer.
    trvrb committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    3ab6845 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    87d4623 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2019

  1. Configuration menu
    Copy the full SHA
    2469e74 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2019

  1. Configuration menu
    Copy the full SHA
    6f22d9f View commit details
    Browse the repository at this point in the history
  2. Shift buildUrls from getAvailable API to byline

    Auspice (2.*) allows the `getAvailable` API request to define `buildUrl`s for datasets. These were displayed in the sidebar, above the choose-dataset dropdowns. 
    
    This commit removes the sidebar display of this, as it's been super-seeded by the byline.
    
    The commit also sets the `metadata.buildUrl` to be that defined in the `getAvailable` API response _if_ it has not been set via the dataset JSON, as the latter is to be considered the "canonical" way of defining this value.
    jameshadfield committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    3bc81f6 View commit details
    Browse the repository at this point in the history
  3. refactor byline into react component

    Refactors the byline into its own React Component. In general, I think this helps reduce interpretability of the code. No changes in UI. Minimal changes to implementation, related to making this a functional component which are simpler than react classes (and react is generally moving away from classes).
    jameshadfield committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    e28d3b2 View commit details
    Browse the repository at this point in the history
  4. Change font size & weight

    Feels much cleaner to me, but this is highly subjective!
    jameshadfield committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    c1c44c6 View commit details
    Browse the repository at this point in the history
  5. Code cleanup

    The "should i render" boolean approach is replaced with returning a react component when it's determined that something should be rendered, else returning `null` as a fallthrough at the end of the function (null is better than `<span/>`). 
    
    The `renderLink` function is replaced by a component, which gets passed props rather than an object.
    
    Looks like lots of changes but not that many really!
    jameshadfield committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    4c44f89 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e179e60 View commit details
    Browse the repository at this point in the history
  7. Split difference in byline font

    The originally intention was to have the overall weight (including size, color and font weight) of byline to be about halfway between title and info. I see that the weight 700 wasn't working. This looks a little better to my eye while still incorporating direction implemented by @jameshadfield.
    trvrb committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    d4ac068 View commit details
    Browse the repository at this point in the history