-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display repo and maintainers as byline #821
Commits on Nov 12, 2019
-
Include byline as part of Info component
This byline includes both repository and maintainers where available in metadata. This replaces the use of maintainers in footer.
Configuration menu - View commit details
-
Copy full SHA for 3ab6845 - Browse repository at this point
Copy the full SHA 3ab6845View commit details -
Configuration menu - View commit details
-
Copy full SHA for 87d4623 - Browse repository at this point
Copy the full SHA 87d4623View commit details
Commits on Nov 13, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 2469e74 - Browse repository at this point
Copy the full SHA 2469e74View commit details
Commits on Nov 20, 2019
-
eslint: Allow functions to be used before they're defined
See commit message of nextstrain/nextstrain.org@fc4aee3 for rationale
Configuration menu - View commit details
-
Copy full SHA for 6f22d9f - Browse repository at this point
Copy the full SHA 6f22d9fView commit details -
Shift buildUrls from getAvailable API to byline
Auspice (2.*) allows the `getAvailable` API request to define `buildUrl`s for datasets. These were displayed in the sidebar, above the choose-dataset dropdowns. This commit removes the sidebar display of this, as it's been super-seeded by the byline. The commit also sets the `metadata.buildUrl` to be that defined in the `getAvailable` API response _if_ it has not been set via the dataset JSON, as the latter is to be considered the "canonical" way of defining this value.
Configuration menu - View commit details
-
Copy full SHA for 3bc81f6 - Browse repository at this point
Copy the full SHA 3bc81f6View commit details -
refactor byline into react component
Refactors the byline into its own React Component. In general, I think this helps reduce interpretability of the code. No changes in UI. Minimal changes to implementation, related to making this a functional component which are simpler than react classes (and react is generally moving away from classes).
Configuration menu - View commit details
-
Copy full SHA for e28d3b2 - Browse repository at this point
Copy the full SHA e28d3b2View commit details -
Feels much cleaner to me, but this is highly subjective!
Configuration menu - View commit details
-
Copy full SHA for c1c44c6 - Browse repository at this point
Copy the full SHA c1c44c6View commit details -
The "should i render" boolean approach is replaced with returning a react component when it's determined that something should be rendered, else returning `null` as a fallthrough at the end of the function (null is better than `<span/>`). The `renderLink` function is replaced by a component, which gets passed props rather than an object. Looks like lots of changes but not that many really!
Configuration menu - View commit details
-
Copy full SHA for 4c44f89 - Browse repository at this point
Copy the full SHA 4c44f89View commit details -
Configuration menu - View commit details
-
Copy full SHA for e179e60 - Browse repository at this point
Copy the full SHA e179e60View commit details -
Split difference in byline font
The originally intention was to have the overall weight (including size, color and font weight) of byline to be about halfway between title and info. I see that the weight 700 wasn't working. This looks a little better to my eye while still incorporating direction implemented by @jameshadfield.
Configuration menu - View commit details
-
Copy full SHA for d4ac068 - Browse repository at this point
Copy the full SHA d4ac068View commit details