URL queries to better support iframe usage #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameshadfield
temporarily deployed
to
auspice-iframe-mtwbapzp2abw69e
jameshadfield
changed the title
This implements a long-desired feature, and is important for iFrames (there's a hack in the code to close it for iFrames on gisaid which can now be removed). Intended behavior: * In narrative mode, neither the URL nor the dataset can specify the sidebar state as we always want it open. * If it has been set via URL / JSON, then crossing the window-width threshold when we would normally toggle the sidebar does nothing. * Setting via URL overrides any JSON setting (as per other behavior in auspice). If neither is set, then we query the window size, as before. * Auspice itself will not modify the URL query, it must be specified manually.
This is desirable for embedding nextstrain viz in other sites via iFrame. It simply doesn't render the header / footer. Note the sidebar is can still be toggled, but can be set to closed via a different URL query.
jameshadfield
temporarily deployed
to
auspice-iframe-mtwbapzp2abw69e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages for more details.
You can see a proof-of-principle iframe here: https://jameshadfield.github.io/nextstrain-iframe/ which uses the HTML
Closes #878
Closes #879