Slightly revise entropy blending on branches #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It had been such that a branch with 80% certainty in a particular location was completely gray. This felt off. In the revised behavior, we hit fully gray at about 50% certainty. This originally leaned quite heavily on gray because we were concerned that measures like 80% shouldn't actually be interpreted as "80%" due to over-confidence in the phylogeo reconstruction. Now, augur traits has --sampling-bias-correction, which corrects this at the source. Better to have auspice give an honest accounting at this point.
jameshadfield
temporarily deployed
to
auspice-entropy-blendin-vnbbv2
|
Tested side-by-side on most of the popular datasets and this looks good. Will release ASAP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It had been such that a branch with 80% certainty in a particular location was completely gray. This felt off. In the revised behavior, we hit fully gray at about 50% certainty. This originally leaned quite heavily on gray because we were concerned that measures like 80% shouldn't actually be interpreted as "80%" due to over-confidence in the phylogeo reconstruction. Now, augur traits has
--sampling-bias-correction, which corrects this at the source. Better to have auspice give an honest accounting at this point.Viewable in Heroku review app. A couple good places to look: