Switch will mute/unmute instead of play/stop #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 7, 2016 21:57
Play/Stop doesnt make sense on a Sonos Playbar, and device.play will return an error on the Playbar. This change modifies the switch behavior to instead Mute/Unmute the speaker. TODO: support both playbar vs play 1 speakers based on device description
Switch will mute/unmute instead of play/stop
|
A simple/dumb solution might be to introduce a config option for muting instead of pausing. Since you have to add one Accessory per room - just add an option like {
"accessories": [
{
"accessory": "Sonos",
"name": "Living Room Speakers",
"room": "Living Room",
"mute": true,
}
]
} |
Play/Stop doesnt make sense on a Sonos Playbar, and device.play will return an error on the Playbar. This change modifies the switch behavior to instead Mute/Unmute the speaker based on a config option.
Play/Stop doesnt make sense on a Sonos Playbar, and device.play will return an error on the Playbar. This change modifies the switch behavior to instead Mute/Unmute the speaker based on a config option.
Conflicts: index.js
|
Thanks for the tip @nfarina . I have added the config option. |
|
Awesome! Ready to merge? |
|
Yes sir! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Play/Stop doesnt make sense on a Sonos Playbar, and this.device.play will return an error on the Playbar.
This change modifies the switch behavior to instead Mute/Unmute the speaker.