Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Ontoly Term Uri generation #381

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Rework Ontoly Term Uri generation #381

merged 2 commits into from
Jun 13, 2024

Conversation

HLWeil
Copy link
Member

@HLWeil HLWeil commented Jun 13, 2024

URL generation does now not always produce PURLs, but different URLs depending on the Ontology namespace.

  "DPBO", OntobeeDPBOParser
  "MS", MSParser
  "PO", POParser
  "RO", ROParser
  "ENVO", BioregistryParser
  "CHEBI", BioregistryParser
  "GO", BioregistryParser
  "OBI", BioregistryParser
  "PATO", BioregistryParser
  "PECO", BioregistryParser
  "TO", BioregistryParser
  "UO", BioregistryParser
  "EFO", BioregistryParser
  "NCIT", BioregistryParser
  "OMP", BioregistryParser

closes #368

Copy link
Collaborator

@Freymaurer Freymaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good!

@HLWeil HLWeil merged commit b66aced into main Jun 13, 2024
2 checks passed
@Hannah-Doerpholz
Copy link

Do you know if (in order to fix the URIs for Swate) the entire SwateDB needs to be reloaded/refreshed?

@Freymaurer
Copy link
Collaborator

The database does not contain any URI information only the ids themselves. So no reload required!

@Hannah-Doerpholz
Copy link

RO purls were fixed so normal parsing with Bioregistry (obofoundry purls) should work. You can see the full issue here: oborel/obo-relations#799 (comment)

@Freymaurer
Copy link
Collaborator

@Hannah-Doerpholz please open a new issue for this. Otherwise it might get lost 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Collection] IRI Generation
3 participants