Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expand uninstall support #15

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: expand uninstall support #15

wants to merge 2 commits into from

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Mar 24, 2023 •
edited
Loading

Proposed changes

Add uninstall support to allow uninstallation of both NMS and modules

Closes #6

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@pdabelf5 pdabelf5 requested a review from jswongF5 as a code owner March 24, 2023 10:47
@jswongF5 jswongF5 requested a review from alessfg March 27, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jswongF5 jswongF5 Awaiting requested review from jswongF5 jswongF5 is a code owner

@alessfg alessfg Awaiting requested review from alessfg

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support 'uninstall' type
1 participant
@pdabelf5