Skip to content
This repository has been archived by the owner on May 24, 2023. It is now read-only.

Add latency metrics support #21

Merged
merged 4 commits into from
Sep 24, 2020
Merged

Add latency metrics support #21

merged 4 commits into from
Sep 24, 2020

Conversation

LorcanMcVeigh
Copy link
Contributor

@LorcanMcVeigh LorcanMcVeigh commented Sep 21, 2020

Proposed changes

Add support for the Prometheus latency metric.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @LorcanMcVeigh

please see my comments

docs/nginx-ingress-controller.md Outdated Show resolved Hide resolved
deploy/crds/k8s.nginx.org_nginxingresscontrollers_crd.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@LorcanMcVeigh LorcanMcVeigh merged commit 0590898 into master Sep 24, 2020
@Dean-Coakley Dean-Coakley deleted the latency-metrics branch September 24, 2020 17:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants