Skip to content
This repository has been archived by the owner on May 24, 2023. It is now read-only.

Add new CRDs for KIC 1.7 #4

Merged
merged 1 commit into from
Apr 1, 2020
Merged

Add new CRDs for KIC 1.7 #4

merged 1 commit into from
Apr 1, 2020

Conversation

Rulox
Copy link
Contributor

@Rulox Rulox commented Mar 27, 2020

Proposed changes

  • Add the creation of the new CRDs for KIC (TransportServer and GlobalConfiguration)
  • Add 2 new fields to the CR (enable passthrough and GlobalConfiguration)
  • Fix a problem with SCC when not in Openshift (API returns an error in k8s, but that error should not be taken as a real error if the Resource definition doesn't exist. There is no specific check for this, so the only way we have right now to filter the error is with error msg)
  • Make sure ClusterRole is updated when Operator runs for the first time. This is due to possible changes in the ClusterRole (For instance, adding new CRDs, like this example).

Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rulox there is a small bug in RBAC. For that, changes are requested.
Please also see additional comments.

pkg/controller/nginxingresscontroller/rbac.go Outdated Show resolved Hide resolved
pkg/controller/nginxingresscontroller/rbac_test.go Outdated Show resolved Hide resolved
pkg/controller/nginxingresscontroller/utils.go Outdated Show resolved Hide resolved
Copy link
Contributor

@Dean-Coakley Dean-Coakley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm pending implementation of @pleshakov feedback

Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Rulox Rulox merged commit 7c45d7d into master Apr 1, 2020
@Rulox Rulox deleted the update-crds branch April 1, 2020 17:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants