This repository has been archived by the owner on May 24, 2023. It is now read-only.
Fix updating ClusterRoleBinding on NIC deletion #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix the construction of the updated list of subjects for the ClusterRoleBinding. Previously, the subjects that matched the NginxIngressController resource name OR namespace were wrongly removed. * Stop reconciliation after removing the finalizer. Previously, the reconciliation would proceed and it would wrongly restore the subject for the NginxIngressController resource that was deleted.
pleshakov
force-pushed
the
fix-clusterrolebinding
branch
from
77a6802
to
6dd287c
Compare
lucacome
approved these changes
Apr 1, 2021
ciarams87
approved these changes
Apr 2, 2021
soneillf5
approved these changes
Apr 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
the ClusterRoleBinding. Previously, the subjects that matched
the NginxIngressController resource name or namespace were wrongly
removed.
reconciliation would proceed and it would wrongly restore the
subject for the NginxIngressController resource that was deleted.
Fixes #89