Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add const labels to upMetric #96

Merged
merged 1 commit into from
Apr 17, 2020
Merged

Add const labels to upMetric #96

merged 1 commit into from
Apr 17, 2020

Conversation

robert-toth
Copy link

@robert-toth robert-toth commented Apr 17, 2020 •
edited
Loading

Proposed changes

Related to Issue 95

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING guide
  • I have proven my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have ensured the README is up to date
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch on my own fork

Dean-Coakley
Dean-Coakley approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@Dean-Coakley Dean-Coakley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Dean-Coakley Dean-Coakley added the bug An issue reporting a potential bug label Apr 17, 2020
@Dean-Coakley Dean-Coakley linked an issue Apr 17, 2020 that may be closed by this pull request
ConstLabels not included in upMetric #95
Closed
Rulox
Rulox approved these changes Apr 17, 2020
View reviewed changes
Copy link

@Rulox Rulox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Dean-Coakley Dean-Coakley merged commit 6a9964b into nginxinc:master Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rulox Rulox Rulox approved these changes

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

@pleshakov pleshakov Awaiting requested review from pleshakov

Assignees
No one assigned
Labels
bug An issue reporting a potential bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ConstLabels not included in upMetric
3 participants
@robert-toth @Rulox @Dean-Coakley