exporter: link to actual metricsPath #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
pleshakov
added
the
enhancement
pleshakov
reviewed
May 1, 2020
exporter.go
Outdated
| <head><title>NGINX Exporter</title></head> | ||
| <body> | ||
| _, err := fmt.Fprintf(w, `<!DOCTYPE html> | ||
| <meta charset="utf-8"> |
There was a problem hiding this comment.
not sure if meta is neccesary, because the exporter already includes the charset in the response header:
$ curl http://localhost:9113/ -I
HTTP/1.1 200 OK
. . .
Content-Type: text/html; charset=utf-8
There was a problem hiding this comment.
Right, I've removed it.
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
pleshakov
approved these changes
May 4, 2020
|
@greut thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The HTML on the
/path show an hardcoded value for the metrics path. This fixes it.Checklist
Before creating a PR, run through this checklist and mark each as complete.