Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngrok: parse error responses and surface the msg and code #104

Merged
merged 3 commits into from
Aug 17, 2023

Conversation

jrobsonchase
Copy link
Collaborator

Resolves ngrok-private/ngrok#21498

Adds an ErrResp proto struct and an NgrokError trait.

The ErrResp gets parsed from the stringly-typed error message that
comes from tunnel protocol RPC calls, and holds both the messge and code
fields. The NgrokError trait allows us to bubble these fields up
through the thiserror wrappings to make it easier to get the ngrok
code/message at the top-level, i.e. ConnectError and RpcError.

@bobzilladev
Copy link
Contributor

Nice, thanks for doing this parsing.

I started seeing that oauth error in similar tests for python, in addition to google-site-verification i also search for the generic accounts.google.com which seems currently dependable.

@jrobsonchase jrobsonchase merged commit 4aa52ad into main Aug 17, 2023
11 checks passed
@jrobsonchase jrobsonchase deleted the josh/nicer-error-type branch August 17, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants