ngrok: support connecting through either http or socks5 proxies #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrobsonchase
force-pushed
the
josh/proxy-url-support
branch
2 times, most recently
from
c24d50b
to
3cfdbcf
Compare
jrobsonchase
force-pushed
the
josh/proxy-url-support
branch
2 times, most recently
from
5480679
to
abdf813
Compare
bobzilladev
approved these changes
Aug 22, 2023
jrobsonchase
force-pushed
the
josh/ngrok/mutable-builder
branch
from
3c746db
to
1bcb220
Compare
jrobsonchase
force-pushed
the
josh/proxy-url-support
branch
from
3aa069b
to
31a9582
Compare
|
@bobzilladev Do you think it needs more documentation than any other session builder methods? Apart from the |
jrobsonchase
force-pushed
the
josh/proxy-url-support
branch
from
91d87a8
to
bac7bbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves ngrok-private/ngrok#21250
Adds a
SessionBuilder::proxy_urlmethod that sets the session up toconnect via either an http or a socks5 proxy. As with
ngrok-go, theseare mutually-exclusive with the
connectorand will override thatsetting.
Errors from unsupported proxy schemes, like inngrok-go, are deferredto connect time. This isn't great, but we're kinda stuck with it since
builder method errors will consume the builder without hope of graceful
recovery, which is also bad. Might be time to re-evaluate #95.
Rebased this on #107, so we get config-time errors for unsupported proxies 🎉