Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ngrok: add Error impls for common pointer types #120

Merged
merged 1 commit into from
Oct 27, 2023
Merged

ngrok: add Error impls for common pointer types #120

merged 1 commit into from
Oct 27, 2023

Conversation

jrobsonchase
Copy link
Collaborator

Adds Error impls for & references, Boxes, and Arcs where the type they
point to implements Error.

@jrobsonchase
Copy link
Collaborator Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

nikolay-ngrok
nikolay-ngrok approved these changes Oct 26, 2023
View reviewed changes
Copy link

@nikolay-ngrok nikolay-ngrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jrobsonchase jrobsonchase merged commit 40a99c4 into main Oct 27, 2023
11 checks passed
@jrobsonchase jrobsonchase deleted the josh/common-error-pointers branch October 27, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikolay-ngrok nikolay-ngrok nikolay-ngrok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrobsonchase @nikolay-ngrok